[Bug 783521] gl: Add "direct" dmabuf uploader
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Nov 1 07:43:46 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=783521
--- Comment #64 from Michael Olbrich <m.olbrich at pengutronix.de> ---
This should fix most failures.
test_upload_data is a bit more complicated. The test already not quite correct:
It checks if the return value of gst_gl_upload_perform_with_buffer() is FALSE.
But that function returns a GstGLUploadReturn.
In this case it returns GST_GL_UPLOAD_RECONFIGURE. I can make the test work
with this change, but I'm not sure if weakening the check like this is correct:
diff --git a/gst-libs/gst/gl/gstglupload.c b/gst-libs/gst/gl/gstglupload.c
index bd438d65d415..0ef3f1048a82 100644
--- a/gst-libs/gst/gl/gstglupload.c
+++ b/gst-libs/gst/gl/gstglupload.c
@@ -2013,7 +2013,7 @@ restart:
if (last_impl != upload->priv->method_impl) {
GstCaps *caps = gst_gl_upload_transform_caps (upload, upload->context,
GST_PAD_SINK, upload->priv->in_caps, NULL);
- if (!gst_caps_is_equal (upload->priv->out_caps, caps)) {
+ if (!gst_caps_is_subset (caps, upload->priv->out_caps)) {
gst_buffer_replace (&outbuf, NULL);
ret = GST_GL_UPLOAD_RECONFIGURE;
}
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list