[Bug 732553] codecparsers: h264: fix identification of EOSEQ and EOS NALs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=732553

--- Comment #8 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
(In reply to Gwenole Beauchesne from comment #3)
> (In reply to comment #2)
> > (From update of attachment 279679 [details] [review])
> > Makes sense, but why don't we scan for next start code if nalu->size == 1?
> 
> We can only reach res == GST_H264_PARSER_OK && nalu->size == 1 if we have an
> EOSEQ or EOS. Once we got that, we cannot parse the next start code because
> it may not exist at all. This is OK because... we definitely don't have
> anything past an EOS NAL unit, and we might not have anything either after
> an EOSEQ.

^ That's untrue. Whenever 5 first bytes of a NAL is sent, this check will
succeed.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.