[Bug 797174] rtsp-server: Receiver streams affect latency on the whole pipeline and cause poor performance in senders

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797174

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373769|none                        |needs-work
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373769:
 --> (https://bugzilla.gnome.org/review?bug=797174&attachment=373769)

Just minor things left, thanks!

::: gst/rtsp-server/rtsp-latency-bin.c
@@ +125,3 @@
+    case PROP_ELEMENT:
+      if (!gst_rtsp_latency_bin_add_element (latency_bin,
+          g_value_get_object (value))) {

This is problematic: properties should always be transfer-none :)

@@ +308,3 @@
+
+  switch (transition) {
+    case GST_STATE_CHANGE_PAUSED_TO_PLAYING:

Also PLAYING_TO_PLAYING

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.