[Bug 797095] vaapipostproc: deinterlace does not take effect with media-driver

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797095

Soon, Thean Siew <thean.siew.soon at intel.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thean.siew.soon at intel.com

--- Comment #5 from Soon, Thean Siew <thean.siew.soon at intel.com> ---
It seems like it's due to the reason where gstreamer-vaapi will only call
driver's VP pipeline if it's ADI. Code as below in
gst/vaapi/gstvaapipostproc.c:

if (postproc->flags) {
    /* Use VA/VPP extensions to process this frame */
    if (postproc->has_vpp &&
        (postproc->flags != GST_VAAPI_POSTPROC_FLAG_DEINTERLACE ||
            deint_method_is_advanced (postproc->deinterlace_method))) {
      ret = gst_vaapipostproc_process_vpp (trans, buf, outbuf);
      if (ret != GST_FLOW_NOT_SUPPORTED)
        goto done;
      GST_WARNING_OBJECT (postproc, "unsupported VPP filters. Disabling");
    }

    /* Only append picture structure meta data (top/bottom field) */
    if (postproc->flags & GST_VAAPI_POSTPROC_FLAG_DEINTERLACE) {
      ret = gst_vaapipostproc_process (trans, buf, outbuf);
      if (ret != GST_FLOW_NOT_SUPPORTED)
        goto done;
    }
  }

I did a quick test on my side by calling gst_vaapipostproc_process_vpp even
though it's not ADI, and BOB deinterlace works correctly with media driver. Is
there any specific reason with the current code where it will call VP pipeline
only if it's ADI?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.