[Bug 759867] gl: Add support to compose VideoOverlayCompositionMeta before the display sink

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Oct 2 11:16:26 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=759867

--- Comment #16 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #15)
> Now if you do the overlay composition before glvideomixer, you have the
> problem that glvideomixer could scale the inputs itself just before doing
> its thing. And that would be now *after* burning the overlays into the
> actual video frame from what I understand. Scaling of inputs in glvideomixer
> happens at the composition stage, not in the glcolorconvert before, right?

Yea, scaling in glvideomixer (the bin and element) is on composition rather
than in a preceding element.

> IMHO this shouldn't block this patchset but should just get a FIXME comment
> somewhere in the code.

I have a small modification for making gloverlaycompositor send the window size
upstream.  For glvideomixer, that probably also needs to either prefer the
current sized caps (something glimagesink could do with as well) that's not
currently easy with caps negotiation or implement a 'render-size event/query'.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list