[Bug 765275] matroska: Add encrypted content support in matroskademux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373817|none                        |reviewed
             status|                            |

--- Comment #51 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 373817:
 --> (https://bugzilla.gnome.org/review?bug=765275&attachment=373817)

Looks good overall.

::: gst/matroska/matroska-demux.c
@@ +174,3 @@
     * gst_matroska_demux_subtitle_caps (GstMatroskaTrackSubtitleContext *
     subtitlecontext, const gchar * codec_id, gpointer data, guint size);
+static const gchar *gst_matroska_track_encryption_algorithm_name (gint val);

Coding style looks weird here, interesting `gst-indent` accept it.

@@ +1524,3 @@
+          gst_structure_set (s, "original-media-type", G_TYPE_STRING,
+              gst_structure_get_name (s), NULL);
+          gst_structure_set (s, "encryption-algorithm", G_TYPE_STRING,

`gst_matroska_track_encryption_algorithm_name` should not return "Nill" as a
string but NULL and handle it on the caller side, or a proper default.

::: gst/matroska/matroska-read-common.c
@@ +404,3 @@
+
+  /* Encrypted buffer */
+  if (signal_byte & GST_MATROSKA_BLOCK_ENCRYPTED) {

I would use an early return here instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.