[Bug 797226] gst: Fix string leak when G_VALUE_COLLECT_INIT() was failed

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Oct 3 18:07:49 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797226

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373809|none                        |reviewed
             status|                            |

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373809
  --> https://bugzilla.gnome.org/attachment.cgi?id=373809
tests: caps: Add more broken caps test case

>+      gst_caps_new_simple ("test/wrong-field",
>+          "foo", GST_TYPE_FRACTION, "bar", NULL));

I think this is misleading - what assertion does this produce for you?

If we want to exercise the "passed '0' as denominator for `GstFraction'" error
code path, then we should pass a proper fraction with a 0 denominator, not
wrong code which may or may not crash depending on how it's handled.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list