[Bug 797251] webrtcbin: might leak resources when changing to NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797251

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373849|none                        |needs-work
             status|                            |

--- Comment #3 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
Review of attachment 373849:
 --> (https://bugzilla.gnome.org/review?bug=797251&attachment=373849)

I'm not sure this is needed or what it changes for you?

Execution of tasks are already blocked on webtrtc->priv->is_closed which is set
to TRUE when the peerconnection thread is shutdown on _dispose().  Can you
check that gst_webrtc_bin_dispose() is being called for you?  If not, that
indicates a leak of the element itself.

::: ext/webrtc/gstwebrtcbin.c
@@ +627,3 @@
   PC_LOCK (op->webrtc);
+  if (!op->webrtc->priv->running) {
+    GST_DEBUG_OBJECT (op->webrtc, "Element is not running, aborting
execution");

Do the unit tests pass with this addition?

A lot of the media tests perform the entire test in the NULL state which seems
like this would prevent.

@@ +3784,3 @@
     case GST_STATE_CHANGE_PAUSED_TO_READY:
       webrtc->priv->running = FALSE;
+      PC_LOCK (webrtc);

This lock should probably one line up protecting the running = FALSE.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.