[Bug 797251] webrtcbin: might leak resources when changing to NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797251

Matthew Waters (ystreet00) <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #16 from Matthew Waters (ystreet00) <ystreet00 at gmail.com> ---
This one is better.  Tests pass :).

commit c4fe52395b21b54fd6ee6b9a5010737404889242
Author: Aleix Conchillo Flaqué <aleix at oblong.com>
Date:   Fri Oct 5 12:10:06 2018 -0700

    webrtcbin: start and stop thread when changing state

    It might be possible that if we set webrtcbin to the NULL state some
    tasks (idle sources) are still executed and they might even freeze. The
freeze
    is caused because the webrtcbin tasks don't hold a reference to webrtcbin
and
    if it's last unref inside the idle source itself this will not allow the
main
    loop to finish because the main loop is waiting on the idle source to
finish.

    We now start and stop webrtcbin thread when changing states. This will
allow
    the idle sources to finish properly.

    https://bugzilla.gnome.org/show_bug.cgi?id=797251

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.