[Bug 785684] rtspconnection: Add API for sending multiple messages at once, and for having the message body consist of multiple chunks of memory

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=785684

--- Comment #31 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373682
  --> https://bugzilla.gnome.org/attachment.cgi?id=373682
rtsp-connection: Add support for new g_output_stream_writev() API

Don't know if this can really easily be reviewed...

So instead you get some nitpicks.

This

>+    /* All other data is borrowed */
>+    g_free (serialized_messages[i].data);

is duplicated a million times everywhere, maybe that should be moved into an
gst_rtsp_serialized_message_clear() inline function?


>+/**
>+ * gst_rtsp_watch_send_messages:
>+ * @watch: a #GstRTSPWatch
>+ * @messages: (array length=n_messages): the messages to send
>+ * @n_messages: the number of messages to send
>+ * @id: (out) (allow-none): location for a message ID or %NULL
>+ *
>+ * Send a @messages using the connection of the @watch. If it cannot be sent
>+ * immediately, it will be queued for transmission in @watch. The contents of
>+ * @messages will then be serialized and transmitted when the connection of the
>+ * @watch becomes writable. In case the @messages is queued, the ID returned in
>+ * @id will be non-zero and used as the ID argument in the message_sent
>+ * callback once the last message is sent.
>+ *
>+ * Returns: #GST_RTSP_OK on success.
>+ */

This sounds like it was copy'n'pasted, it talks about messages as if it's a
single message, should be updated to describe the expected behaviour now that
it's multiple ones, e.g. will the callback be called for each message with the
id or only for the last one?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.