[Bug 771525] gst-rtsp-server: Poor performance with interleaved RTSP due to missing buffer list support and merging of all memories in buffers

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=771525

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373685|none                        |reviewed
             status|                            |

--- Comment #30 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373685
  --> https://bugzilla.gnome.org/attachment.cgi?id=373685
rtsp-client: Add support for sending buffer lists directly

Looks reasonable to the extent that it can be reviewed.


>+static gboolean
>+do_send_messages (GstRTSPClient * client, GstRTSPMessage * messages,
>+    guint n_messages, gboolean close, gpointer user_data)
>+{
>+  ...
>+
>+  for (i = 0; i < n_messages; i++) {
>+    if (gst_rtsp_message_get_type (&messages[i]) == GST_RTSP_MESSAGE_DATA) {
>+      guint8 channel = 0;
>+      GstRTSPResult r;
>+
>+      /* FIXME: We assume that all data messages in the list are for the
>+       * same channel */
>+      r = gst_rtsp_message_parse_data (&messages[i], &channel);

Is that something that needs fixing before merging? It seems like a reasonable
assumption to me in our context? Maybe it needs documenting somewhere?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.