[Bug 765079] srtpdec request-key is not signaled if roc is missing

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765079

--- Comment #4 from Aleix Conchillo Flaqué <aconchillo at gmail.com> ---
(In reply to Olivier Crête from comment #3)
> @Josep I'm not sure if this is the right fix.. Shouldn't you just not be
> including the key at all in the caps, forcing the element to do the request?
> I'm not sure why you put the key in the caps in the first place if you need
> the ROC to make sense of it.
> 
> I'm tempted to just revert this and the related patch from bug #786304.
> 
> This break "srtpenc ! srtpdec! as srtpenc doesn't put the roc in it's caps!

I guess this comment is for me, not Josep. I don't recall much about this, but
it doesn't add the key in the caps, only ROC. If ROC is not found it will just
request the key (and the rest of needed fields). But certainly, it breaks
"strpenc ! strpdec".

The documentation is correct though:

'''
If no rollover counter is provided by the user, 0 is used by default.
'''

Looking at it, it feels that removing this patch should just be ok because we
will provide the "roc" when "request-key" is emitted.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.