[Bug 797283] gst: add some gdb python macros

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Tue Oct 16 07:32:31 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797283

--- Comment #4 from Michael Olbrich <m.olbrich at pengutronix.de> ---
(In reply to Thibault Saunier from comment #2)
> Review of attachment 373925 [details] [review]:
> 
> Looks good overall but I could not get it working without hacks, also it
> would be great to have it working in a `gst-build` uninstalled env (just
> need to slitgly adapt PYTHONPATH there, I can do it).
> 
> ::: gst/gst_gdb.py
> @@ +5,3 @@
> +try:
> +    GLIB_FOUND = True
> +    from gobject_gdb import g_type_to_name, g_type_name_from_instance
> 
> Here `gobject_gdb` is not in PYTHONPATH ever, any idea why?

Right, this only works if gst_gdb.py is in the same directory as
gobject_gst.py from glib.
I'm not really happy with this solution. I'd like to reuse the helper
functions but they are not really public. Maybe I should just copy them
for now.

> @@ +7,3 @@
> +    from gobject_gdb import g_type_to_name, g_type_name_from_instance
> +
> +except:
> 
> Be explicit about the catched exception type.

ok.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list