[Bug 797293] splitmuxsink: Do not hardcode frames_of_daily_jam
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Tue Oct 16 13:08:06 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=797293
Vivia Nikolaidou <vivia at ahiru.eu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #373942|accepted-commit_now |committed
status| |
--- Comment #3 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 373942:
--> (https://bugzilla.gnome.org/review?bug=797293&attachment=373942)
commit af0e30d5452d87117dd6371fd15e213af5524ac4 (HEAD -> master, origin/master,
origin/HEAD)
Author: Vivia Nikolaidou <vivia at ahiru.eu>
Date: Tue Oct 16 15:42:12 2018 +0300
splitmuxsink: Do not hardcode frames_of_daily_jam
Apart from the obvious drawbacks of hardcoding, the drawback here was
that, if we subtracted 2 frames (instead of 2.6) from the target running
time, we'd request the next keyframe a bit too far into the future,
which would make our files split at the wrong position.
https://bugzilla.gnome.org/show_bug.cgi?id=797293
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list