[Bug 797299] x264enc: Print full option-string applied to x264_encoder in debug log ...

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797299

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |slomo at coaxion.net
 Attachment #373954|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 373954
  --> https://bugzilla.gnome.org/attachment.cgi?id=373954
[1/2] x264enc: Don't use hard-coded constant value in nal type check

Looks good to me but please explain in the commit message what you do exactly,
why and what it fixes. Definitely makes sense to not hardcode this though, it
will just fall apart sooner or later if x264enc behaviour changes slightly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.