[Bug 796326] waylandsink: don't check if buffer used by compositor when attach

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Oct 18 07:36:44 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796326

--- Comment #3 from Haihua Hu <jared.hu at nxp.com> ---
(In reply to Nicolas Dufresne (ndufresne) from comment #2)
> Review of attachment 372326 [details] [review]:
> 
> Would be nice to show in your comment message your analyses that explain
> that this case is legal and is not a bug elswhere in the resize code.

Hi, sorry for late response. We found we still need check this boolean. But
could we not use g_return_if_fail, Because it will report error log.

Can we just add some check and return:

-  g_return_if_fail (self->used_by_compositor == FALSE);
+  if (self->used_by_compositor) {
+    GST_DEBUG_OBJECT (self, "buffer used by compositor %p", self->gstbuffer);
+    return;
+  }

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list