[Bug 797303] rtpbasepayload: Update seqnum property correctly

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Oct 18 12:04:16 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797303

--- Comment #2 from Linus Svensson <linus.svensson at axis.com> ---
(In reply to Sebastian Dröge (slomo) from comment #1)
> Review of attachment 373961 [details] [review]:
> 
> ::: gst-libs/gst/rtp/gstrtpbasepayload.c
> @@ +1308,3 @@
>      gst_buffer_list_foreach (GST_BUFFER_LIST_CAST (obj), filter_meta, NULL);
> +    /* sequence number has increased more if this was a buffer list */
> +    payload->seqnum = data.seqnum - 1;
> 
> Why -1?

data.seqnum is currently used to keep track of the next sequence number to use.
It's set to priv->next_seqnum in the beginning, and every call to set_headers
(in the loop) will end with an increment.

priv->next_seqnum is set to data.seqnum at the end of _prepare_push().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list