[Bug 797305] New: srtp: Add support for MKI
GStreamer (GNOME Bugzilla)
bugzilla at gnome.org
Thu Oct 18 19:29:58 UTC 2018
https://bugzilla.gnome.org/show_bug.cgi?id=797305
Bug ID: 797305
Summary: srtp: Add support for MKI
Classification: Platform
Product: GStreamer
Version: git master
OS: Linux
Status: NEW
Severity: normal
Priority: Normal
Component: gst-plugins-bad
Assignee: gstreamer-bugs at lists.freedesktop.org
Reporter: olivier.crete at ocrete.ca
QA Contact: gstreamer-bugs at lists.freedesktop.org
GNOME version: ---
Currently, our SRTP elements don't support MKIs. This patch series adds support
for them.
It has 2 parts:
* Encoder
I just added an MKI property and then it puts a "mki" element in the caps with
the MKI in a buffer. This still only allows for one MKI.
* Decoder
This may be a bit more controversial, as I'm allowing multiple MKIs, instead of
having separate CAPS, I'm putting them all in one with "srtp-key=X, mki=X,
mki2=Y, srtp-key2=Y, mki3=Z, srtp-key3=Z", up to 15, which is the maximum
allowed by libsrtp.
The other thing that could be controversial is that support for MKIs were added
in libsrtp 2.1. So I put the whole thing behind ifdeds, included the extra MKI
property. If no one yells, I would be tempted to just drop the ifdefs and
require libsrtp 2.1 at least for everyone.
I'm also attaching a patch against Cerbero to bump libsrtp to 2.2.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
More information about the gstreamer-bugs
mailing list