[Bug 797289] dispatch write never ends

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797289

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373969|none                        |needs-work
             status|                            |

--- Comment #11 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373969:
 --> (https://bugzilla.gnome.org/review?bug=797289&attachment=373969)

Almost there :)

::: gst/rtsp-server/rtsp-stream.c
@@ +4354,3 @@
+    send_tcp_message (stream, idx);
+  g_mutex_unlock (&priv->lock);
+  g_object_unref (stream);

This should be removed and ...

@@ +4392,3 @@
+    /* When appsink running this callback we want to send as much as we can
+     * But when idle callback or watch callback is running we will first
+     * queue an idle probe */

Maybe add some explanation here why we do that, what it prevents.

@@ +4397,3 @@
+      idle_src = g_idle_source_new ();
+      g_source_set_callback (idle_src, (GSourceFunc) cb_send_tcp_message,
+          g_object_ref (stream), NULL);

... be added here as destroy notify instead.

Otherwise you'll leak the stream if the main context is never polled again
(e.g. because it is shut down).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.