[Bug 797239] qtdemux: Crash when playing smooth-streaming

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797239

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373975|none                        |reviewed
             status|                            |

--- Comment #19 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373975
  --> https://bugzilla.gnome.org/attachment.cgi?id=373975
qtdemux: Don't use g_ptr_array_find_with_equal_func()

>+/* g_ptr_array_find_with_equal_func is available since 2.54,
>+ * replacement until we can depend unconditionally on the real one in GLib */
>+static gboolean
>+qtdemux_ptr_array_find_with_equal_func (GPtrArray * haystack,
>+    gconstpointer needle, GEqualFunc equal_func, guint * index_)
>+{
>...
>+}

I think this should be done conditionally, like this:

#if !GLIB_CHECK_VERSION(2,56,0)
#define g_ptr_array_find_with_equal_func qtdemux_ptr_array_find_with_equal_func
>+static gboolean
>+g_ptr_array_find_with_equal_func (GPtrArray * haystack,
>+    gconstpointer needle, GEqualFunc equal_func, guint * index_)
>+{
>...
>+}
#endif

which makes it easier to grep for it later when we bump the GLib req, and
avoids the duplication if GLib is new enough.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.