[Bug 797289] dispatch write never ends

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797289

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373991|none                        |reviewed
             status|                            |

--- Comment #15 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373991:
 --> (https://bugzilla.gnome.org/review?bug=797289&attachment=373991)

Looks good just one more question

::: tests/check/gst/client.c
@@ +682,3 @@
   fail_unless (gst_rtsp_client_set_connection (client, conn));

+  maincontext = g_main_context_new ();

There is no main loop running on this main context. Is this a problem? We could
have GSources pending that are never called but are supposed to be called. Like
the one you just added

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.