[Bug 797316] Implement fetch-bootstrap and bootstrap --offline

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797316

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373987|none                        |reviewed
             status|                            |

--- Comment #8 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373987:
 --> (https://bugzilla.gnome.org/review?bug=797316&attachment=373987)

::: cerbero/bootstrap/__init__.py
@@ +38,3 @@
+    'android-ndk-r16-darwin-x86_64.zip':
'589a567c4fc84f5f7219cae56d199b63059033e08512b6d8132739c90ef9483d',
+    'android-ndk-r16-windows-x86_64.zip':
'fb4ce0bbcb927dc1bb507d3dbb1aef0f243e5184b3dd5d956a450bcf4b0808df',
+    'android-ndk-r16-windows-x86.zip':
'aaa52b9e8b283be1249376f7373704687a5b13106575f613378e6d44c663f782',

Shouldn't these be in the specific bootstrappers where also the URLs are
defined?

::: cerbero/bootstrap/windows.py
@@ +42,3 @@
+
+# Extra binary dependencies
+GNOME_FTP = 'https://ftp.gnome.org/pub/gnome/binaries/win32/'

Shouldn't this be downloads.gnome.org?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.