[Bug 797326] matroska-demux leaks caps

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797326

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374012|none                        |needs-work
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 374012:
 --> (https://bugzilla.gnome.org/review?bug=797326&attachment=374012)

::: gst/matroska/matroska-demux.c
@@ +3279,3 @@
           gst_pad_set_caps (new_track->pad, new_track->caps);
         }
+        gst_caps_replace (&old_track->caps, NULL);

The gst_matroska_track_free(old_track) a few lines below should unref the caps
already, but it doesn't... can you move this code there, and also check if
other things would have to be freed there too?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.