[Bug 797299] x264enc: Print full option-string applied to x264_encoder in debug log ...

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797299

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374020|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 374020:
 --> (https://bugzilla.gnome.org/review?bug=797299&attachment=374020)

::: ext/x264/gstx264enc.c
@@ +106,3 @@
 #include <gst/video/gstvideometa.h>
 #include <gst/video/gstvideopool.h>
+#include <gst/base/gstbytereader.h>

You need to add $(GST_BASE_LIBS) and $(GST_BASE_CFLAGS) to Makefile.am for
this, and gstbase_dep to meson.build

@@ +1968,3 @@
+
+  /* skip uuid_iso_iec_11578 */
+  if (!gst_byte_reader_skip (&br, 16)) {

Could this be used to distinguish any SEI_USER_DATA_UNREGISTERED from the one
we actually care for here?

@@ +1975,3 @@
+  sei_msg_payload = g_malloc (payload_size);
+  memcpy (sei_msg_payload, sei + gst_byte_reader_get_pos (&br), payload_size);
+  sei_msg_payload[payload_size - 1] = 0;

Wouldn't you override the last character here in case the payload is not
NUL-terminated already?

@@ +2017,3 @@
+#ifndef GST_DISABLE_GST_DEBUG
+      guint8 *sei = NULL;
+      guint skip_bits = 0;

This is bytes, not bits, isn't it?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.