[Bug 797304] rtpsession: The RTP timestamp in the RTCP Sender Report may be completely wrong

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797304

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373976|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373976:
 --> (https://bugzilla.gnome.org/review?bug=797304&attachment=373976)

::: gst/rtpmanager/rtpsession.c
@@ +1079,3 @@
+
+  g_hash_table_foreach (sess->ssrcs[sess->mask_idx], (GHFunc) reset_source,
+      NULL);

I think we should actually remove all the sources here. They're not going to
make any sense the next time the element is started up again.

But there are a couple of other things that should also be reset in rtpsession:
last_rtcp_check_time and the other timeout related fields, first_rtcp, and
various other fields.

::: gst/rtpmanager/rtpsource.c
@@ +258,3 @@
+  g_queue_foreach (src->retained_feedback, (GFunc) gst_buffer_unref, NULL);
+  g_queue_clear (src->retained_feedback);
+  src->last_rtptime = -1;

This looks correct

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.