[Bug 790115] video: add SMPTE 2086 meta API for partially supporting HDR

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=790115

--- Comment #18 from Seungha Yang <pudding8757 at gmail.com> ---
(In reply to Sebastian Dröge (slomo) from comment #17)
> Review of attachment 374054 [details] [review]:
> ::: gst-libs/gst/video/video-hdr.c
> @@ +56,3 @@
> +  g_return_val_if_fail (minfo != NULL, NULL);
> +
> +  return g_strdup_printf ("%lf:%lf:%lf:%lf:%lf:%lf:%lf:%lf:%lf:%lf",
> 
> That many fields in a single string is not very readable IMHO, but I don't
> have a better suggestion either :)
> 
> Also this is unfortunately locale dependant: on a German locale a , would be
> used as decimal separator instead of a . There's some API in GLib to do it
> locale-independent.

What if we use fraction instead of double? I found there might be precision
error during converting between double and string using g_ascii_dtostr(). This
precision error makes equality check difficult 

> @@ +92,3 @@
> +                                                           const gchar *
> level);
> +
> +struct _GstVideoHDR {
> 
> This struct does not seem to be used anywhere, I don't think we need it?

That's actually used by the patch "videodecoder: Forward upstream HDR info. to
downstream" but seems to redundant. I'll check whether adding it is really
required or not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.