[Bug 797345] wasapisrc - does not drain devices of buffers when reading leading to dropped audio

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797345

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374068|none                        |reviewed
             status|                            |

--- Comment #1 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 374068:
 --> (https://bugzilla.gnome.org/review?bug=797345&attachment=374068)

Looks good to me overall, can be merged after these comments are addressed.
Thanks, this should improve things a lot!

::: sys/wasapi/gstwasapisrc.c
@@ +477,1 @@


The + 1 here means we now use a minimum of 3 segments? Why is that? The comment
would need to be updated with that explanation.

@@ +598,3 @@
+      self->overflow_buffer_length -= n;
+    }
+  }

I think it's probably simpler to use GstAdapter here instead of managing memory
by hand. It was made specifically for this use-case.

@@ +650,3 @@
+      if ((flags & mask_handled) != 0) {
+        GST_INFO_OBJECT (self, "buffer flags=%#08x", (guint) flags);
+      }

This should probably be split into a separate patch?

@@ +669,3 @@
+      } else {
+        memcpy (data_ptr, from, read_len);
+      }

This should also be a separate patch? To write zeroes for silence.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.