[Bug 797344] gst-inspect: Pipe stdout to less if not piped already

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sat Oct 27 17:00:59 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797344

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374067|none                        |needs-work
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 374067:
 --> (https://bugzilla.gnome.org/review?bug=797344&attachment=374067)

Generally looks good

::: tools/gst-inspect.c
@@ +1716,3 @@
+
+      while ((count = read (STDIN_FILENO, buffer, sizeof (buffer) - 1)) > 0)
+        write (STDOUT_FILENO, buffer, count);

Need to handle EAGAIN/EINTR here at least

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list