[Bug 797338] dshowvideosrc: add device-index, add GstDeviceMonitor, and several fixes

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797338

Nirbheek Chauhan <nirbheek.chauhan at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374048|none                        |needs-work
             status|                            |

--- Comment #16 from Nirbheek Chauhan <nirbheek.chauhan at gmail.com> ---
Review of attachment 374048:
 --> (https://bugzilla.gnome.org/review?bug=797338&attachment=374048)

::: sys/dshowsrcwrapper/gstdshowvideosrc.cpp
@@ +497,3 @@
+
+  gst_dshowvideosrc_create_capture_filter (src);
+

The device should indeed not be opened in get_caps, but it should also not be
opened in start(), it should be opened in change_state() when going from NULL
-> READY. See the winks src for an example.

dshowsrcvideo also already has gst_dshowvideosrc_change_state() so this
function need to just be moved there.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.