[Bug 797358] vaapi: build error when GL is enabled and EGL disabled

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797358

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #374113|none                        |needs-work
             status|                            |

--- Comment #2 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 374113:
 --> (https://bugzilla.gnome.org/review?bug=797358&attachment=374113)

Thanks for the patch. It's a good catch.


A nitpick: the subject line, should start with the namespace of "plugins: ...".
You can look the formats of the commits in that file.

::: gst/vaapi/gstvaapipluginutil.c
@@ +195,3 @@
     return GST_VAAPI_DISPLAY_TYPE_EGL;
+#else
+  (void) gl_platform_type;

Tricking the compiler perhaps here is not the best option. I would take a
different approach: move the declaration of gl_platform_type into the guarded
block. To say:

#if USE_EGL
  {
       const gchar *const gl_platform_type = g_getenv ("GST_GL_PLATFORM");
       if (g_strcmp0 (gl_platform_type, "egl") == 0
         ...
  }
#endif

and remove the assignation at the beginning of the function

@@ +283,3 @@
+{
+  return NULL;
+}

This is the same approach of above and it only adds spurious code.

Add a

#if USE_EGL && GST_GL_HAVE_PLATFORM_EGL

inside of the function gst_vaapi_create_display_from_egl() as in
gst_vaapi_get_egl_handle_from_gl_display()

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.