[Bug 765275] matroska: Add encrypted content support in matroskademux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=765275

--- Comment #48 from y.bandou <bandou.yacine at gmail.com> ---
(In reply to Xabier Rodríguez Calvar from comment #47)
> Review of attachment 365211 [details] [review]:
> 
> I have no more comments about the rest, but what I say does impact in what I
> would wait as a client of this.
> 
> ::: gst/matroska/matroska-read-common.c
> @@ +3084,3 @@
> +              /* system_id field is set to "UNDEFINED" because it isn't
> specified neither in WebM nor in Matroska spec. */
> +              event =
> +                  gst_event_new_protection ("UNDEFINED", keyId_buf,
> 
> This seems a bit like a hack to me. What I think it would be best would be
> to modify this API to allow nil values.

I agree with you, see the comments 38 and 39.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.