[Bug 797086] New: [PATCH] matroskamux: don't store used UIDs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Wed Sep 5 23:29:26 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797086

            Bug ID: 797086
           Summary: [PATCH] matroskamux: don't store used UIDs
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: mkelly at xevo.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 373551
  --> https://bugzilla.gnome.org/attachment.cgi?id=373551&action=edit
0001-matroskamux-don-t-store-used-UIDs.patch

Currently, whenever we generate a 128-bit UID, we store it in a list and
return 0 if we ever encounter a collision. This is so mathematically
improbable that it's not worth checking for, so we can save memory and
time by not tracking the UID. Even if a collision happened, a list of
only 10 UIDs would be unlikely to detect it.

This article has a good description of how improbable a collision is:
https://en.wikipedia.org/wiki/Universally_unique_identifier#Collisions

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list