[Bug 797086] matroskamux: don't store used UIDs

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 6 18:05:42 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797086

--- Comment #8 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
GLib have it's own RNG, which is documented not recommended for crypto. It's
seeded from urandom on Linux, rand_s on Win32 and wallclock time otherwise. But
this is not crypto, we just want to avoid collision, we don't care if one can
predict the values. That UID cache was initially global, so it's not the first
time it becomes a bottleneck. I think the explanation for the change are fair
enough, and will improve performance over long period of time.

https://gitlab.gnome.org/GNOME/glib/blob/master/glib/grand.c#L62

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list