[Bug 797098] downloadbuffer: does not recover from failed seek

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797098

Alicia Boya García <aboya at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373561|none                        |needs-work
             status|                            |

--- Comment #2 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 373561:
 --> (https://bugzilla.gnome.org/review?bug=797098&attachment=373561)

::: plugins/elements/gstdownloadbuffer.c
@@ +626,3 @@

+  /* Note: We keep the lock while waiting for the event. Should the seek fail,
+   * we don't want the chain function to lose any data. */

This won't work when the seek succeeds, it will deadlock when the source
synchronously sends an event (e.g. appsrc sends FLUSH_START).

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.