[Bug 796831] composition: Output one single segment "per seek"

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Sun Sep 9 15:22:53 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=796831

Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373569|none                        |accepted-commit_now
             status|                            |

--- Comment #3 from Nicolas Dufresne (ndufresne) <nicolas at ndufresne.ca> ---
Review of attachment 373569:
 --> (https://bugzilla.gnome.org/review?bug=796831&attachment=373569)

While I'm not fan of the encoder behaviour with segments, I think this change
do make sense. The composition endup making the upper layer look like a single
stream, not leaking the upstream complexity into the downstream elements. This
change basically makes the stream time match the rendering (the output),
instead of jumping around. I think it will make the nlecomposition much less of
a special case, and help prevent later regressions.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list