[Bug 797130] decklink: sometimes displays a flashed frame of a previously played sequence

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797130

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373618|accepted-commit_now         |reviewed
             status|                            |

--- Comment #6 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373618:
 --> (https://bugzilla.gnome.org/review?bug=797130&attachment=373618)

::: sys/decklink/gstdecklinkvideosink.cpp
@@ +928,3 @@
+      /* cause sometimes decklink stops without notifying us... */
+      guint64 wait_time = g_get_monotonic_time () + G_TIME_SPAN_SECOND;
+      g_cond_wait_until (&self->output->cond, &self->output->lock, wait_time);

I was wondering if a timeout should maybe be an error message here, but at
least should be logged as a GST_WARNING

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.