[Bug 797133] qtmux: Allow up to 1 audio sample of lateness in prefill mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797133

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373621|none                        |reviewed
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373621:
 --> (https://bugzilla.gnome.org/review?bug=797133&attachment=373621)

::: gst/isomp4/gstqtmux.c
@@ +3483,3 @@
+        /* allow up to 1 sample of lateness */
+        trak_lateness = gst_util_uint64_scale (diff,
+            atom_trak_get_timescale (qtpad->trak), GST_SECOND);

The timescale is not necessarily 1 sample (i.e. 1 audio sample, 1 video frame,
etc: for video it usually is a 100th of a frame) but can be almost anything.

I think this generally makes sense though. While you do this now not only in
prefill mode (please change the commit message), there's not much point in
adding such a small entry.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.