[Bug 797133] qtmux: Allow up to 1 audio sample of lateness in prefill mode

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797133

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373633|none                        |committed
             status|                            |

--- Comment #7 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 373633:
 --> (https://bugzilla.gnome.org/review?bug=797133&attachment=373633)

commit 94f8603411d607aa125f31d48786c8bbf10eab25 (HEAD -> upstream_master,
upstream/master)
Author: Vivia Nikolaidou <vivia at ahiru.eu>
Date:   Wed Sep 12 17:24:00 2018 +0300

    qtmux: Allow up to 1 trak timescale unit of lateness in prefill mode

    For 59.94 FPS, it's common to set 60000 as timescale. For that
    timescale, if the audio is late by as little as 0:00:00.000016666
    (definitely less than one audio sample), lateness gets rounded to 1.
    Added a safeguard that allows lateness up to 1 sample with the specific
    trak's timescale, to make sure that values less than e.g. one audio
    sample won't break the prefill mode. What will happen in this case is
    that the audio will get squeezed back to the video's timestamp, which in
    practice means that the audio will be 0.000016666 seconds early (with
    the patch).

    https://bugzilla.gnome.org/show_bug.cgi?id=797133

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.