[Bug 797146] uri: fix roundtrip for file:// URIs

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797146

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373661|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373661:
 --> (https://bugzilla.gnome.org/review?bug=797146&attachment=373661)

::: gst/gsturi.c
@@ +1958,3 @@
+          uri->port != GST_URI_NO_PORT) || (uri->userinfo == NULL
+          && uri->host == NULL && uri->port == GST_URI_NO_PORT
+          && uri->scheme != NULL))

>From your fix it seems like a problem on the serialization side. The fields of
the URI are all set correctly when parsing file URIs it seems?

Just unclear if these are *all* the cases where a // should be appended at this
position, and if this is not causing too many // to be added. E.g.
"whateverscheme:someid" would also cause // to be added or not, or would
parsing put "someid" into the userinfo then?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.