[Bug 797157] glsinkbin: Leak if sink is not sink-ref'd in a specific order

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797157

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |slomo at coaxion.net
         Resolution|---                         |INVALID

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
This is a bug in your code.

With ref_sink() first you take ownership of the reference, and glsink is not
going to take ownership of it (aka it takes another reference).

If you ref_sink() afterwards, then glsink will take ownership of the reference
(it calls ref_sink() itself!) and you don't own it anymore (at all, you must
keep another reference around otherwise!).

Check the documentation in GObject for floating references. It's all awful but
that's just how it is currently :)


Note that there was a bug in glsink up to 1.14.2 related to this:
58ac815eae6ed468d1db60a54a1bd34d6324c28c and
c2a7c938404a50306ef9c2048fc51c41d0c36b45 fixes it.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.