[Bug 797143] vaapih265dec: support 422 chroma format hevc decode.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797143

--- Comment #6 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #5)
> Review of attachment 373669 [details] [review]:
> 
> ::: gst-libs/gst/vaapi/gstvaapicontext.c
> @@ +141,3 @@
> +    else
> +      surface = gst_vaapi_surface_new (GST_VAAPI_OBJECT_DISPLAY (context),
> +          cip->chroma_type, cip->width, cip->height);
> 
> Why do you need to use gst_vaapi_surface_new_with_format(), why
> gst_vaapi_surface_new() doesn't work for you?

I guess it is because you need to use a new version of vaCreateSurfaces with
attributes.

It that case I think it would be better to change gst_vaapi_surface_new() to
use 
gst_vaapi_surface_create_full() if libva is >=0.34 and use the current code as
fallback.

Also, all you new code of setting YUY2 should be guarded too.

> 
> In other words, why do you need to convert from GST_VIDEO_FORMAT_YUY2 to
> GST_VAAPI_CHROMA_TYPE_YUV422, and then to VA_RT_FORMAT_YUV422 again?
> 
> ::: gst-libs/gst/vaapi/gstvaapiutils_h265.c
> @@ +138,3 @@
>  
> +  switch (sps->profile_tier_level.profile_idc) {
> +    case GST_H265_PROFILE_IDC_MAIN:
> 
> all the changes from GST_H265_PROFILE_ to GST_H265_PROFILE_IDC_ belongs to a
> different patch because it is a different fix. Please, split it, because it
> would need to be backported to 1.14 and 1.12
> 
> Good catch!

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.