[Bug 797152] vaapidec: leak of dmabuf fds when transitioning from PLAYING to NULL state

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797152

--- Comment #5 from Sakari Kapanen <sakari.m.kapanen at gmail.com> ---
Interestingly, if I disable this call to gst_vaapi_buffer_proxy_release_data:
https://github.com/GStreamer/gstreamer-vaapi/blob/b4d6a3b11338c188b2c6d47533732c0e0f28c39d/gst/vaapi/gstvaapivideomemory.c#L1026
then the fds are closed by vaReleaseBufferHandle in
gst_vaapi_buffer_proxy_release_handle just fine.

If I'm reading the code correctly, the gst_vaapi_buffer_proxy_release_data call
seems to destroy the underlying VAAPI image object using vaDestroyImage, which
seems to also destroy the underlying buffer:
https://github.com/intel/intel-vaapi-driver/blob/master/src/i965_drv_video.c#L4985

Therefore, the later call to vaReleaseBufferHandle (when freeing the resources
allocated by the pipeline) fails because on the VAAPI driver side, the
underlying buffer is already destroyed. Does this make sense at all? I hope I
followed the code correctly.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.