[Bug 797152] vaapidec: leak of dmabuf fds when transitioning from PLAYING to NULL state

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797152

--- Comment #8 from Sakari Kapanen <sakari.m.kapanen at gmail.com> ---
(In reply to Víctor Manuel Jáquez Leal from comment #7)
> If I recall correctly, in order to use those buffers for decoding, the
> allocated derive image must be released, otherwise the driver couldn't write
> on the surface.
That's what I also gathered from the comments in the code.

> I don't know if that changed in the intel-vaapi-driver, or how's the
> situation with media-driver or amd state-tracker.
I could reproduce the same leak on the media-driver at least (normally running
intel-vaapi-driver though).

> Could you post a patch, removing that data release and run tests with it?
Removing the data release broke the actual application I'm working on - no
decoded frames could be received and displayed. So that doesn't seem to be the
way to go at least.

I'm not quite confident with writing a patch for this issue since the solution
is not likely going to be as simple as removing the data release. Despite, it
seems to me that the solution would be something along the lines of
gstreamer-vaapi taking ownership of that dmabuf fd (since the VAAPI driver
won't know about that handle or buffer anymore since the buffer is destroyed on
VAAPI side by the data release call) and taking care of closing it later.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.