[Bug 793333] matroskademux: Allow Matroska headers to be read more than once

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Sep 20 18:06:58 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=793333

Thibault Saunier <tsaunier at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #368183|none                        |accepted-commit_now
             status|                            |

--- Comment #11 from Thibault Saunier <tsaunier at gnome.org> ---
Review of attachment 368183:
 --> (https://bugzilla.gnome.org/review?bug=793333&attachment=368183)

OK, this change makes a sense even if ideally we should verify that everything
matches and fail in a clean way. With that patch we just get a failure later
on, before we were just ignoring the content following the second header.

Without that we can't play YouTube anymore with WebKitGTK since they are now
using MSE/matroska and it is **really** not ideal, while that patch is maybe
not perfect I think it is a good starting point to get things working and in
the future we might want to add more checks to handle the case where the track
topology changes with new headers, even if the behaviour in that case is not
specified in matroska itself.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list