[Bug 797185] Fix API export/import decorators in general and "inconsistent DLL linkage" with MSVC on Windows

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 21 10:26:20 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797185

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Created attachment 373722
  --> https://bugzilla.gnome.org/attachment.cgi?id=373722&action=edit
libs: figure out right export define in configure

Add new GST_API_EXPORT in config.h and use that for GST_*_API
decorators instead of GST_EXPORT.

The right export define depends on the toolchain and whether
we're using -fvisibility=hidden or not, so it's better to set it
to the right thing directly than hard-coding a compiler whitelist
in the public header.

We put the export define into config.h instead of passing it via the
command line to the compiler because it might contain spaces and brackets
and in the autotools scenario we'd have to pass that through multiple
layers of plumbing and Makefile/shell escaping and we're just not going
to be *that* lucky.

The export define is only used if we're compiling our lib, not by external
users of the lib headers, so it's not a problem to put it into config.h

Also, this means all .c files of libs need to include config.h
to get the export marker defined, so fix up a few that didn't
include config.h.

This commit depends on a common submodule commit that makes gst-glib-gen.mak
add an #include "config.h" to generated enum/marshal .c files for the
autotools build.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list