[Bug 797145] avwait: Send dropping=true message after all streams stopped

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 21 14:20:39 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797145

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373728|none                        |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 373728:
 --> (https://bugzilla.gnome.org/review?bug=797145&attachment=373728)

Just two minor things left

::: gst/timecode/gstavwait.c
@@ +818,3 @@
             if (self->recording) {
               self->audio_running_time_to_end_at =
self->running_time_to_end_at;
+              self->must_send_end_message = END_MESSAGE_STREAM_ENDED;

|= here too

@@ +1132,3 @@
+  if (send_element_message) {
+    g_mutex_lock (&self->mutex);
+    if (self->must_send_end_message & END_MESSAGE_VIDEO_PUSHED ||

Put the x & y into parenthesis

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list