[Bug 797145] avwait: Send dropping=true message after all streams stopped

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Sep 21 14:34:15 UTC 2018


https://bugzilla.gnome.org/show_bug.cgi?id=797145

Vivia Nikolaidou <vivia at ahiru.eu> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373730|none                        |committed
             status|                            |

--- Comment #15 from Vivia Nikolaidou <vivia at ahiru.eu> ---
Review of attachment 373730:
 --> (https://bugzilla.gnome.org/review?bug=797145&attachment=373730)

commit b1b4a043388188cd7dd0ab87d1771d89d12b3ca4 (HEAD -> upstream_master,
upstream/master)
Author: Vivia Nikolaidou <vivia at ahiru.eu>
Date:   Fri Sep 14 16:05:20 2018 +0300

    avwait: Send dropping=true message after all streams stopped

    Previously it was dispatched before the last video buffer, and audio
    buffers would follow afterwards. It's misleading to send the
    dropping=true message before both streams have really stopped, it can
    lead to races when someone is e.g. waiting for that message to send EOS.

    Also added some debug output.

    https://bugzilla.gnome.org/show_bug.cgi?id=797145

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list