[Bug 793333] matroskademux: Allow Matroska headers to be read more than once

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=793333

--- Comment #20 from Alicia Boya García <aboya at igalia.com> ---
Review of attachment 373732:
 --> (https://bugzilla.gnome.org/review?bug=793333&attachment=373732)

::: gst/matroska/matroska-demux.c
@@ +3138,3 @@

+static GstFlowReturn
+gst_matroska_demux_reparse_tracks (GstMatroskaDemux * demux, GstEbmlRead *
ebml)

OK.

@@ +3178,3 @@
+            gst_matroska_read_common_stream_from_num (&demux->common,
+            new_track->num);
+    switch (id) {

Mismatches are already checked in the previous if(). In fact,
gst_matroska_read_common_stream_from_num() and
gst_matroska_read_common_tracknumber_unique() are very similar, apart from
their return values and the fact that
gst_matroska_read_common_stream_from_num() does some warning reporting that is
redundant in this case.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.