[Bug 797164] x264enc: Avoid format decision per frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797164

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk
 Attachment #373687|none                        |rejected
             status|                            |

--- Comment #3 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 373687
  --> https://bugzilla.gnome.org/attachment.cgi?id=373687
x264enc: Add some G_UNLIKELY macro

I know we use these macros everywhere, but I've actually been removing them
when touching code. I think they make the code harder to read and have
virtually no measurable effect anywhere apart from the tightest inner loops. In
GLib there were even cases where the compiler did the wrong/opposite thing when
these macros where used IIRC (but I might be making this up).

So if you don't mind too much I would like to give this patch a miss unless you
have performance data that shows significant improvements from sprinkling these
here.

I don't mind turning the x264enc NULL check into an early return in itself
though.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.