[Bug 797143] vaapih265dec: support 422 chroma format hevc decode.

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=797143

Víctor Manuel Jáquez Leal <vjaquez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #373752|none                        |reviewed
             status|                            |

--- Comment #21 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373752:
 --> (https://bugzilla.gnome.org/review?bug=797143&attachment=373752)

::: gst-libs/gst/vaapi/video-format.c
@@ +287,3 @@
  **/
 GstVideoFormat
+gst_vaapi_video_format_get_best_native (GstVideoFormat format, guint chroma)

ouch! this is not what I had in mind. There's no reason to have the same
function for two different tasks.

My idea was to add the function gst_vaapi_video_format_from_chroma() and this
function would be used too by gst_vaapi_video_fromat_get_best_native() 

If I get time today, I will change it and push your patch

--- Comment #22 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> ---
Review of attachment 373752:
 --> (https://bugzilla.gnome.org/review?bug=797143&attachment=373752)

::: gst-libs/gst/vaapi/video-format.c
@@ +287,3 @@
  **/
 GstVideoFormat
+gst_vaapi_video_format_get_best_native (GstVideoFormat format, guint chroma)

ouch! this is not what I had in mind. There's no reason to have the same
function for two different tasks.

My idea was to add the function gst_vaapi_video_format_from_chroma() and this
function would be used too by gst_vaapi_video_fromat_get_best_native() 

If I get time today, I will change it and push your patch

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.